compilerplugins/clang/test/unnecessaryoverride.cxx

   1 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
   2 /*
   3  * This file is part of the LibreOffice project.
   4  *
   5  * This Source Code Form is subject to the terms of the Mozilla Public
   6  * License, v. 2.0. If a copy of the MPL was not distributed with this
   7  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
   8  */
   9
  10 #include <sal/config.h>
  11
  12 #include <config_clang.h>
  13 #include <o3tl/typed_flags_set.hxx>
  14
  15 struct Base
  16 {
  17     virtual ~Base();
  18     virtual void f();
  19     void variadic(int, ...);
  20     void cv() const volatile;
  21     void ref();
  22     static void staticFn();
  23     void defaults(void* = nullptr, int = 0, double = 1, Base const& = {}, char const* = "foo");
  24 };
  25
  26 struct SimpleDerived : Base
  27 {
  28     void
  29     f() override // expected-error {{public virtual function just calls public parent [loplugin:unnecessaryoverride]}}
  30     {
  31         Base::f();
  32     }
  33 };
  34
  35 struct Intermediate1 : Base
  36 {
  37 };
  38
  39 struct MultiFunctionIntermediate2 : Base
  40 {
  41     void f() override;
  42 };
  43
  44 struct MultiFunctionDerived : Intermediate1, MultiFunctionIntermediate2
  45 {
  46     void f() override { Intermediate1::f(); } // no warning
  47 };
  48
  49 struct MultiClassIntermediate2 : Base
  50 {
  51 };
  52
  53 struct MultiClassDerived : Intermediate1, MultiClassIntermediate2
  54 {
  55     void f() override { Intermediate1::f(); } // no warning
  56 };
  57
  58 struct DerivedDifferent : Base
  59 {
  60     void variadic(int x) { Base::variadic(x); } // no warning
  61     void cv() { Base::cv(); } // no warning
  62     void ref() && { Base::ref(); } // no warning
  63     void staticFn() { Base::staticFn(); } // no warning
  64     void defaults(void* x1, int x2, double x3, Base const& x4, char const* x5)
  65     {
  66         Base::defaults(x1, x2, x3, x4, x5); // no warning
  67     }
  68 };
  69
  70 struct DerivedSame : Base
  71 {
  72     void
  73     defaults( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
  74         void* x1 = 0, int x2 = (1 - 1), double x3 = 1.0, Base const& x4 = (Base()),
  75         char const* x5 = "f"
  76                          "oo")
  77     {
  78         Base::defaults(x1, x2, x3, x4, x5);
  79     }
  80 };
  81
  82 struct DerivedSlightlyDifferent : Base
  83 {
  84     void defaults( // no warning
  85         void* x1 = nullptr, int x2 = 0, double x3 = 1, Base const& x4 = DerivedSlightlyDifferent(),
  86         char const* x5 = "foo")
  87     {
  88         Base::defaults(x1, x2, x3, x4, x5);
  89     }
  90 };
  91
  92 enum class E
  93 {
  94     E1 = 1,
  95     E2 = 2,
  96     E3 = 4
  97 };
  98 namespace o3tl
  99 {
 100 template <> struct typed_flags<E> : is_typed_flags<E, 7>
 101 {
 102 };
 103 }
 104
 105 struct Base2
 106 {
 107     void default1(Base const& = SimpleDerived());
 108     void default2(Base const& = SimpleDerived());
 109     void default3(Base = Base());
 110     void default4(E = (E::E1 | E::E2 | E::E3));
 111 };
 112
 113 struct Derived2 : Base2
 114 {
 115     void default1(Base const& x = Intermediate1()) { Base2::default1(x); } // no warning
 116     void
 117     default2( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
 118         Base const& x = SimpleDerived())
 119     {
 120         Base2::default2(x);
 121     }
 122     void
 123     default3( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
 124         Base x = Base())
 125     {
 126         (Base2::default3(x));
 127     }
 128     void
 129     default4( // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
 130         E x = (E::E1 | E::E2 | E::E3))
 131     {
 132         Base2::default4(x);
 133     }
 134 };
 135
 136 class Base3
 137 {
 138 public:
 139     void f1();
 140 };
 141
 142 class Derived3 : protected Base3
 143 {
 144 public:
 145     // effectively changing access from protected to public
 146     void f1() { Base3::f1(); }
 147 };
 148
 149 // check the case where the method occurs more than once in a direct path up the class hierarchy
 150 struct Base4
 151 {
 152     void f1();
 153 };
 154 struct Derived4_1 : public Base4
 155 {
 156     void f1();
 157 };
 158 struct Derived4_2 : public Derived4_1
 159 {
 160     void
 161     f1() // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
 162     {
 163         Derived4_1::f1();
 164     }
 165 };
 166
 167 struct Base5_1
 168 {
 169     void f1();
 170 };
 171 struct Base5_2
 172 {
 173     void f1();
 174 };
 175 struct Derived5 : public Base5_1, public Base5_2
 176 {
 177     void f1() { Base5_1::f1(); } // no warning expected
 178 };
 179
 180 struct Base6_1
 181 {
 182     bool f1();
 183 };
 184 struct Derived6 : public Base6_1
 185 {
 186     bool
 187     f1() // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}}
 188     {
 189         bool ret = Base6_1::f1();
 190         return ret;
 191     }
 192 };
 193 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */