Extended loplugin:ostr manual changes
commitd98e014cf6d4cea7ebd7898cbc9124f6fba07684
authorStephan Bergmann <sbergman@redhat.com>
Fri, 6 Oct 2023 14:51:17 +0000 (6 16:51 +0200)
committerStephan Bergmann <stephan.bergmann@allotropia.de>
Sun, 28 Apr 2024 09:29:52 +0000 (28 11:29 +0200)
tree195a5e99cea2c8ec6d9bae19cb56f488d75bb6fa
parent817d35eb829db00329ea5437d50e5c682139f505
Extended loplugin:ostr manual changes

I had done these a while ago, when I looked into extending loplugin:ostr to do
more automatic rewriting, and these were places where I needed to do something
manually, for one reason or another, because the automatic rewriting would not
pick it up correctly.

However, I got distracted, and a wholesale automatic rewrite would still run
into cases where an _ostr/_ustr instance from a library's .rodata would still be
referenced after the library has already been dlcose'd.  So I never came around
to finishing all that.

But there appears to be renewed interest in (automatic) rewritings here now, so
it probably makes sense if I share this part of my work anyway.

Change-Id: I3da9d38398e4bca373cb0000a9d34b49a36ad58a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166792
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
14 files changed:
chart2/qa/extras/chart2dump/chart2dump.cxx
connectivity/source/drivers/hsqldb/HDriver.cxx
dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx
i18npool/source/indexentry/indexentrysupplier_default.cxx
include/o3tl/nonstaticstring.hxx [new file with mode: 0644]
include/oox/core/relations.hxx
include/toolkit/helper/macros.hxx
include/vbahelper/vbahelperinterface.hxx
sal/qa/rtl/alloc/rtl_alloc.cxx
sax/source/expatwrap/sax_expat.cxx
sc/qa/unit/ucalc.cxx
svl/qa/unit/svl.cxx
vbahelper/source/vbahelper/vbafontbase.cxx
vcl/workben/vcldemo.cxx