| commit | 93a9b288af3015817b2a4c648a0adcf8d627c6f8 | |
| author | upstream svn <svn@amule.org> | |
| Fri, 6 May 2016 19:39:34 +0000 (6 19:39 +0000) | ||
| committer | Dévai Tamás <gonosztopi@amule.org> | |
| Fri, 6 May 2016 20:05:39 +0000 (6 20:05 +0000) | ||
| tree | 647a6a97a70e864f382b4e54ec08e340d3dadb0f | treesnapshot (tar.gz zip) |
| parent | 322c19e8383218afaba9298fbeb477d518ba06aa | commitdiff |
Add new filter to the sanity checker to check for plain wxFAIL macros
wxFAIL is for the lazy programmer. Most of the time it can be replaced with
an appropriate wxCHECK() macro, making the code even more readable. Okay, I
admit there are cases it is valid to use wxFAIL, but even in these cases one
should use wxFAIL_MSG() instead, to give an explanation on what went wrong at
first sight.
wxFAIL is for the lazy programmer. Most of the time it can be replaced with
an appropriate wxCHECK() macro, making the code even more readable. Okay, I
admit there are cases it is valid to use wxFAIL, but even in these cases one
should use wxFAIL_MSG() instead, to give an explanation on what went wrong at
first sight.
| .svn-revision | diffblobblamehistory | |
| src/utils/scripts/sanity | diffblobblamehistory |