| commit | b6f3ac06eec82b1a9d41a4583261ff022c9e9843 | |
| author | Tom Tromey <tromey@adacore.com> | |
| Mon, 4 Nov 2024 14:31:20 +0000 (4 07:31 -0700) | ||
| committer | Tom Tromey <tromey@adacore.com> | |
| Wed, 20 Nov 2024 20:18:40 +0000 (20 13:18 -0700) | ||
| tree | 1a85f7380abb2bc916e9eba204e5ae7bce81fadf | treesnapshot (tar.gz zip) |
| parent | 1fb5ccd6bfc140c0f542cdd678e5888e18599e59 | commitdiff |
Improve choice sorting in ada-lang.c
ada-lang.c has a "sort_choices" function that claims to sort the
symbol choices, but which does not really implement sorting. This
patch changes this code to really sort the result vector, sorting
first by filename, then line number, and finally by the symbol name.
The filename sorting is done first by comparing basenames. It turns
out that gnatmake and gprbuild invoke the compiler a bit differently,
so depending on which one you use, the results of a naive sort might
be different (due to the use of absolute or relative paths).
ada-lang.c has a "sort_choices" function that claims to sort the
symbol choices, but which does not really implement sorting. This
patch changes this code to really sort the result vector, sorting
first by filename, then line number, and finally by the symbol name.
The filename sorting is done first by comparing basenames. It turns
out that gnatmake and gprbuild invoke the compiler a bit differently,
so depending on which one you use, the results of a naive sort might
be different (due to the use of absolute or relative paths).
| gdb/ada-lang.c | diffblobblamehistory | |
| gdb/testsuite/gdb.ada/overload_menu_crash.exp | diffblobblamehistory | |
| gdb/testsuite/gdb.ada/sym_print_name.exp | diffblobblamehistory |