| commit | 14a62285f0f84886c55eabe7da325d332cfe9992 | |
| author | Laurens Van Houtven <lvh@laurensvh.be> | |
| Mon, 2 Mar 2009 11:24:40 +0000 (2 12:24 +0100) | ||
| committer | Laurens Van Houtven <lvh@laurensvh.be> | |
| Mon, 2 Mar 2009 11:24:40 +0000 (2 12:24 +0100) | ||
| tree | 1e61c030a47441b54761f5d9929021755c39fcaa | treesnapshot (tar.gz zip) |
| parent | 5b868593438cbf535e64f40f47710ca77c249858 | commitdiff |
net.py: typo fix + catch the right exception
net.py previously didn't catch the right exception when calling the cleanup method on its handler. This missed our watchful eye because SequentialHandler, which is usually used, does handle it properly.
1. If it really didn't have such a method, the interpreter throws AttributeError, not NameError
2. If the handler inherits from BaseHandler (which it should) it should raise NotImplementedError.
Signed-off-by: Laurens Van Houtven <lvh@laurensvh.be>
net.py previously didn't catch the right exception when calling the cleanup method on its handler. This missed our watchful eye because SequentialHandler, which is usually used, does handle it properly.
1. If it really didn't have such a method, the interpreter throws AttributeError, not NameError
2. If the handler inherits from BaseHandler (which it should) it should raise NotImplementedError.
Signed-off-by: Laurens Van Houtven <lvh@laurensvh.be>
| code/breadcrumb/server/net.py | diffblobblamehistory |