| commit | 0238e8b8d09e9ebd85c06081d144fe837d52060d | |
| author | bartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 14 Aug 2014 13:58:05 +0000 (14 13:58 +0000) | ||
| committer | bartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 14 Aug 2014 13:59:30 +0000 (14 13:59 +0000) | ||
| tree | 4c807c2a33a0784e3682cd0d5f3d119c2c5947ef | treesnapshot (tar.gz zip) |
| parent | acdce4753e0077a0688e66f52ae180bfdef31464 | commitdiff |
Revert 289532 "Route newly created notifications to notification..."
This CL introduces a memory leak. Line 126 of
notification_conversion_helper.cc contains a new[] that has no
corresponding delete[]:
unsigned char* bitmap_data(new unsigned char[pixel_count * BYTES_PER_PIXEL]);
> Route newly created notifications to notification provider API.
>
> Whenever a new notification is created, route it to an
> extension/app that has notification provider permission.
> Currently, if there's an app with notificationProvider
> permission, notifications will go to both message center
> and that app. In the future, when additional sections in
> Chrome Settings is implemented, this will send notifications
> to only one party based on the user's selection.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/441753002
TBR=liyanhou@chromium.org
Review URL: https://codereview.chromium.org/469313002
Cr-Commit-Position: refs/heads/master@{#289544}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289544 0039d316-1c4b-4281-b951-d872f2087c98
This CL introduces a memory leak. Line 126 of
notification_conversion_helper.cc contains a new[] that has no
corresponding delete[]:
unsigned char* bitmap_data(new unsigned char[pixel_count * BYTES_PER_PIXEL]);
> Route newly created notifications to notification provider API.
>
> Whenever a new notification is created, route it to an
> extension/app that has notification provider permission.
> Currently, if there's an app with notificationProvider
> permission, notifications will go to both message center
> and that app. In the future, when additional sections in
> Chrome Settings is implemented, this will send notifications
> to only one party based on the user's selection.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/441753002
TBR=liyanhou@chromium.org
Review URL: https://codereview.chromium.org/469313002
Cr-Commit-Position: refs/heads/master@{#289544}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289544 0039d316-1c4b-4281-b951-d872f2087c98
12 files changed:
