Update SplitString calls to new form
commit0aa7c64253cca8b636d52d1d01d94f96ab9c13fa
authorbrettw <brettw@chromium.org>
Fri, 7 Aug 2015 00:11:28 +0000 (6 17:11 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 7 Aug 2015 00:12:13 +0000 (7 00:12 +0000)
tree29b825a84dffc4d7310c69b22da0cfd7b1228277
parent924597ba8b5def174aebdc96368545f51df1bee2
Update SplitString calls to new form

Uses the new form for most (but not quite all) of the remaining users of the old form.

Changes media mime util codec list parsing to expect no result from the string "," rather than two empty strings. The old SplitString call had a special case where if the input was empty, it would return empty, but if it had one split character, it would return two empty strings as results.

The new one lets you choose but the options are either (1) empty string -> one empty string and "," -> two empty strings, or (2) map both to no results for when you don't want empty results. I'm pretty sure media codec parsing actually wants the latter behavior, so I updated the call to discard empty results and MimeUtilTest.ParseCodecString is updated.

Review URL: https://codereview.chromium.org/1272823003

Cr-Commit-Position: refs/heads/master@{#342238}
70 files changed:
ash/display/display_manager.cc
ash/test/display_manager_test_api.cc
base/command_line.cc
base/debug/proc_maps_linux.cc
base/process/internal_linux.cc
base/process/process_metrics_linux.cc
base/test/launcher/test_launcher.cc
base/trace_event/trace_config.cc
content/browser/accessibility/browser_accessibility_win.cc
content/browser/accessibility/dump_accessibility_browsertest_base.cc
content/browser/browser_main_loop.cc
content/browser/download/file_metadata_unittest_linux.cc
content/browser/download/save_package.cc
content/browser/loader/resource_dispatcher_host_unittest.cc
content/browser/service_worker/service_worker_browsertest.cc
content/browser/service_worker/service_worker_database.cc
content/browser/web_contents/web_contents_impl.cc
content/child/runtime_features.cc
content/common/gpu/media/jpeg_decode_accelerator_unittest.cc
content/common/gpu/media/video_decode_accelerator_unittest.cc
content/common/gpu/media/video_encode_accelerator_unittest.cc
content/common/pepper_plugin_list.cc
content/common/plugin_list.cc
content/common/plugin_list_win.cc
content/public/browser/desktop_media_id.cc
content/public/common/webplugininfo.cc
content/renderer/manifest/manifest_parser.cc
content/renderer/media/webrtc/stun_field_trial.cc
content/renderer/render_view_impl.cc
content/shell/renderer/layout_test/blink_test_helpers.cc
extensions/browser/api/networking_private/networking_private_linux.cc
extensions/common/csp_validator.cc
extensions/common/features/base_feature_provider.cc
extensions/common/manifest.cc
extensions/common/permissions/socket_permission_data.cc
extensions/common/permissions/socket_permission_entry.cc
extensions/common/url_pattern.cc
extensions/renderer/dispatcher.cc
google_apis/drive/test_util.cc
google_apis/gaia/fake_gaia.cc
google_apis/gaia/gaia_auth_fetcher.cc
google_apis/gaia/gaia_auth_util.cc
gpu/command_buffer/service/feature_info.cc
gpu/config/gpu_control_list.cc
gpu/config/gpu_info_collector.cc
gpu/config/gpu_info_collector_android.cc
gpu/config/gpu_info_collector_linux.cc
gpu/config/gpu_test_expectations_parser.cc
gpu/config/gpu_util.cc
media/base/mime_util.cc
media/base/mime_util_unittest.cc
media/filters/chunk_demuxer_unittest.cc
media/filters/frame_processor_unittest.cc
media/filters/source_buffer_stream_unittest.cc
media/filters/video_cadence_estimator_unittest.cc
media/formats/mp4/avc_unittest.cc
media/formats/mp4/track_run_iterator_unittest.cc
media/renderers/video_renderer_impl_unittest.cc
remoting/protocol/negotiating_host_authenticator.cc
ui/aura/bench/bench_main.cc
ui/base/ime/input_method_auralinux_unittest.cc
ui/events/devices/x11/touch_factory_x11.cc
ui/events/ozone/evdev/event_device_test_util.cc
ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc
ui/gfx/font_fallback_win.cc
ui/gfx/font_list.cc
ui/gfx/render_text_unittest.cc
ui/gl/gl_gl_api_implementation.cc
ui/gl/gl_implementation.cc
ui/views/controls/label.cc