| commit | 0ac319f1f2cf7846540cd9510fe09f807ab2fec7 | |
| author | mtomasz <mtomasz@chromium.org> | |
| Mon, 30 Mar 2015 07:19:38 +0000 (30 00:19 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 30 Mar 2015 07:20:12 +0000 (30 07:20 +0000) | ||
| tree | 12f0a6f693eb9c8f16ca8481bdf5ddff50afffd1 | treesnapshot (tar.gz zip) |
| parent | c78545dbec6276a41f922d0f11c908fcd0d5789a | commitdiff |
Guarantee validity of VolumeInfo via WeakPtr.
Previously, when performing an asynchronous operation, we could end up on doing
the first part and the second part on different volumes if the volume id stayed
the same.
This CL introduces a Volume class which is returned as WeakPtr<Volume>, which
is invalidated when a volume is ejected. So, if a device is ejected and
then another one inserted (with the same volume id), the WeakPtr will be
invalidated, and such earlier mentioned async operation would be able to
abort.
TEST=unit_tests: *VolumeManager*
BUG=None
Review URL: https://codereview.chromium.org/1036563004
Cr-Commit-Position: refs/heads/master@{#322749}
Previously, when performing an asynchronous operation, we could end up on doing
the first part and the second part on different volumes if the volume id stayed
the same.
This CL introduces a Volume class which is returned as WeakPtr<Volume>, which
is invalidated when a volume is ejected. So, if a device is ejected and
then another one inserted (with the same volume id), the WeakPtr will be
invalidated, and such earlier mentioned async operation would be able to
abort.
TEST=unit_tests: *VolumeManager*
BUG=None
Review URL: https://codereview.chromium.org/1036563004
Cr-Commit-Position: refs/heads/master@{#322749}
18 files changed: