| commit | 0f07fbef765278a5da7e21741eb2775419035a4a | |
| author | nednguyen <nednguyen@google.com> | |
| Mon, 16 Mar 2015 21:59:32 +0000 (16 14:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 16 Mar 2015 22:00:07 +0000 (16 22:00 +0000) | ||
| tree | e559b35ff63a8a98a24a2b832e67628fd3439c21 | treesnapshot (tar.gz zip) |
| parent | b386883d993bba40562b565b98da4ffe72e82b1d | commitdiff |
[Telemetry] Make chrome_tracing_agent state more resilient to tracing exception.
Because ChromeTracingAgent class has global states, when any
exception was raised inside StopTracing method, the active tracing
state of this class is not set to False, making subsequent unittest that
try to StartTracing fails because of this.
Long term fix of this depends on crbug.com/317481 be fixed so that
ChromeTracingAgent no longer have global state.
BUG=459807
Review URL: https://codereview.chromium.org/997193002
Cr-Commit-Position: refs/heads/master@{#320799}
Because ChromeTracingAgent class has global states, when any
exception was raised inside StopTracing method, the active tracing
state of this class is not set to False, making subsequent unittest that
try to StartTracing fails because of this.
Long term fix of this depends on crbug.com/317481 be fixed so that
ChromeTracingAgent no longer have global state.
BUG=459807
Review URL: https://codereview.chromium.org/997193002
Cr-Commit-Position: refs/heads/master@{#320799}