| commit | 19c821ae9e9585f4d91356a047c469796034906f | |
| author | tapted <tapted@chromium.org> | |
| Fri, 3 Apr 2015 05:25:55 +0000 (2 22:25 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 3 Apr 2015 05:30:56 +0000 (3 05:30 +0000) | ||
| tree | c73bebf14cc443f9cf33990e17c0a5dfc8971453 | treesnapshot (tar.gz zip) |
| parent | dd7a6481ef8d32d3e5814935d4acc9ed0cf13efc | commitdiff |
[MacViews] Remove stray/unguarded uses of ash/shell.h in cross-platform files
The shell.h header compiles on Mac, but its implementation isn't linked
in, resulting in errors later. This CL was made by putting an #error in
ash/shell.h which gets common cases (but there are more strays for
follow-ups).
Some of these #includes were simply redundant/unused.
app_info_footer_panel.cc has logic for pinning apps to the Ash shelf,
which needed a guard (it was already guarded, but not with #ifdefs).
BUG=425229
Review URL: https://codereview.chromium.org/1054793002
Cr-Commit-Position: refs/heads/master@{#323626}
The shell.h header compiles on Mac, but its implementation isn't linked
in, resulting in errors later. This CL was made by putting an #error in
ash/shell.h which gets common cases (but there are more strays for
follow-ups).
Some of these #includes were simply redundant/unused.
app_info_footer_panel.cc has logic for pinning apps to the Ash shelf,
which needed a guard (it was already guarded, but not with #ifdefs).
BUG=425229
Review URL: https://codereview.chromium.org/1054793002
Cr-Commit-Position: refs/heads/master@{#323626}