| commit | 1dbe123c5e7b2d41e517049c1b98d8ad75563b98 | |
| author | estade <estade@chromium.org> | |
| Tue, 6 Jan 2015 22:45:04 +0000 (6 14:45 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 6 Jan 2015 22:46:01 +0000 (6 22:46 +0000) | ||
| tree | 14772650568220fd4e139e225de5f00eb5e29ecd | treesnapshot (tar.gz zip) |
| parent | 4c559b468d544ddee9f545ad578949ebc02e3919 | commitdiff |
Remove FrameDetached and FrameWillClose listeners from AutofillAgent.
AutofillAgent::FrameDetached is no longer necessary because form_cache_ only holds the forms for a single frame.
AutofillAgent::FrameWillClose is only called on the actual closing frame (which might be a parent frame).
AutofillAgent::FrameDetached can't take the place of AutofillAgent::FrameWillClose because the RenderFrame disables sending IPCs during detachment.
Therefore, move the automatic closing of rAc from the renderer (autofill_agent.cc) to the browser (chrome_autofill_client.cc).
For PasswordAutofillAgent, add FrameDetached to RenderFrameHost.
BUG=433486
Review URL: https://codereview.chromium.org/796493004
Cr-Commit-Position: refs/heads/master@{#310162}
AutofillAgent::FrameDetached is no longer necessary because form_cache_ only holds the forms for a single frame.
AutofillAgent::FrameWillClose is only called on the actual closing frame (which might be a parent frame).
AutofillAgent::FrameDetached can't take the place of AutofillAgent::FrameWillClose because the RenderFrame disables sending IPCs during detachment.
Therefore, move the automatic closing of rAc from the renderer (autofill_agent.cc) to the browser (chrome_autofill_client.cc).
For PasswordAutofillAgent, add FrameDetached to RenderFrameHost.
BUG=433486
Review URL: https://codereview.chromium.org/796493004
Cr-Commit-Position: refs/heads/master@{#310162}
22 files changed: