Revert of Add more components_unittests to GN build (patchset #5 id:80001 of https...
commit1dc9aa14380b7c6c77d80354b86f55ede462766e
authoryosin <yosin@chromium.org>
Sat, 22 Aug 2015 12:05:45 +0000 (22 05:05 -0700)
committerCommit bot <commit-bot@chromium.org>
Sat, 22 Aug 2015 12:06:31 +0000 (22 12:06 +0000)
tree882e6d1e47ae4aeaf2c7d93aa2f276d2e955a21c
parent027a930a4f456a173b5c01d8537185187698caeb
Revert of Add more components_unittests to GN build (patchset #5 id:80001 of https://codereview.chromium.org/1303703004/ )

Reason for revert:
Compilation error in storage_monitor_win_unittest.cc.

GYP build may not compile this file.

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/storage_monitor/unit_tests/storage_monitor_win_unittest.obj.rsp /c ../../components/storage_monitor/storage_monitor_win_unittest.cc /Foobj/components/storage_monitor/unit_tests/storage_monitor_win_unittest.obj /Fdobj/components/storage_monitor/unit_tests_cc.pdb
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(218) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(218) : warning C4267: '=' : conversion from 'size_t' to 'DWORD', possible loss of data
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(298) : warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible loss of data
ninja: build stopped: subcommand failed.

Original issue's description:
> Add more components_unittests to GN build
>
> This adds tests for: url matcher, precache, sync driver, serialization, proxy config, leveldb proto, error page, storage monitor, search provider logos, translate, json schema, guest view, dom distiller, network hints.
>
> CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel
>
> Committed: https://crrev.com/c76a816074e6504b0b4b3420529928057d11b50b
> Cr-Commit-Position: refs/heads/master@{#344974}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1313463002

Cr-Commit-Position: refs/heads/master@{#344976}
23 files changed:
BUILD.gn
build/gn_migration.gypi
chromeos/BUILD.gn
components/BUILD.gn
components/components_tests.gyp
components/dom_distiller/content/BUILD.gn
components/dom_distiller/core/BUILD.gn
components/error_page/renderer/BUILD.gn
components/guest_view/browser/BUILD.gn
components/json_schema/BUILD.gn
components/leveldb_proto/BUILD.gn
components/metrics/BUILD.gn
components/network_hints/renderer/BUILD.gn
components/precache/content/BUILD.gn
components/precache/core/BUILD.gn
components/proxy_config/BUILD.gn
components/search_provider_logos/BUILD.gn
components/storage_monitor/BUILD.gn
components/sync_driver/BUILD.gn
components/translate/core/browser/BUILD.gn
components/translate/core/common/BUILD.gn
components/translate/core/language_detection/BUILD.gn
components/url_matcher/BUILD.gn