Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of...
commit22e2f4a23530e0b22c8f37dd91e4e803a0a6e355
authorwfh <wfh@chromium.org>
Tue, 28 Apr 2015 22:39:21 +0000 (28 15:39 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 28 Apr 2015 22:40:43 +0000 (28 22:40 +0000)
tree700185ddc8d1eefa747915d72fc4a1fbfd20ef2c
parent7c64f265edca18adefe01d0a4e676a3f7b834bd1
Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination.

Wire this into all the existing callers.

Add a new child process watcher in chrome to be notified on child process crashes. This will confirm whether users with RESULT_CODE_INVALID_SANDBOX_STATE are crashing on background start (--no-startup-window) or not. This also adds required framework to paint a sad tab UI from this class in the future.

BUG=472324, 453541
TEST=Apply patch in http://pastebin.com/uEDxngBa and verify histogram ChildProcess.InvalidSandboxStateCrash.NoStartupWindow is recorded.

Review URL: https://codereview.chromium.org/1067733006

Cr-Commit-Position: refs/heads/master@{#327380}
20 files changed:
chrome/browser/browser_process_impl.cc
chrome/browser/browser_process_impl.h
chrome/browser/chrome_child_process_watcher.cc [new file with mode: 0644]
chrome/browser/chrome_child_process_watcher.h [new file with mode: 0644]
chrome/browser/metrics/chrome_stability_metrics_provider.cc
chrome/browser/metrics/chrome_stability_metrics_provider.h
chrome/browser/metrics/plugin_metrics_provider.cc
chrome/browser/metrics/plugin_metrics_provider.h
chrome/chrome_browser.gypi
chromecast/browser/metrics/cast_stability_metrics_provider.cc
chromecast/browser/metrics/cast_stability_metrics_provider.h
components/crash/browser/crash_dump_manager_android.cc
components/crash/browser/crash_dump_manager_android.h
content/browser/bootstrap_sandbox_mac.cc
content/browser/browser_child_process_host_impl.cc
content/browser/mach_broker_mac.h
content/browser/mach_broker_mac.mm
content/public/browser/browser_child_process_observer.h
content/public/browser/child_process_data.h
tools/metrics/histograms/histograms.xml