| commit | 2397ce85ad0afff2ef85b01c5c55cc32902bbf87 | |
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 3 Apr 2014 16:20:23 +0000 (3 16:20 +0000) | ||
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 3 Apr 2014 16:20:23 +0000 (3 16:20 +0000) | ||
| tree | 4da0e718153be055de71e56d2c265001fd8d6d17 | treesnapshot (tar.gz zip) |
| parent | 725926d90ce703cd69b34a48e124f6945f4ae222 | commitdiff |
Add unit test for the Settings API Bubble.
Refactored the helper functions into views-specific code and rest (so that the non-views code can be used in more places).
Fixed a bug where if you have two extensions simultaneously overwriting settings, the bubble now knows which one is active.
Also prevent the bubble from writing the suppress flag when the user choses to disable the extension (that way they get the bubble again if the extension becomes enabled for some reason).
BUG=356204
R=sky@chromium.org, yoz@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/219593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261438 0039d316-1c4b-4281-b951-d872f2087c98
Refactored the helper functions into views-specific code and rest (so that the non-views code can be used in more places).
Fixed a bug where if you have two extensions simultaneously overwriting settings, the bubble now knows which one is active.
Also prevent the bubble from writing the suppress flag when the user choses to disable the extension (that way they get the bubble again if the extension becomes enabled for some reason).
BUG=356204
R=sky@chromium.org, yoz@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/219593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261438 0039d316-1c4b-4281-b951-d872f2087c98