| commit | 25646da121a85f51e54f52c161172d7e5c614aea | |
| author | krasin <krasin@google.com> | |
| Thu, 6 Aug 2015 22:58:40 +0000 (6 15:58 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 6 Aug 2015 22:59:24 +0000 (6 22:59 +0000) | ||
| tree | 6f1415ec620444aeb902c49ec5f429410e9cb5a4 | treesnapshot (tar.gz zip) |
| parent | ce5cab104935d3fedcb3c6af2aec0311be43a812 | commitdiff |
Fix invalid C-style cast in RenderFrameImplTest.
It casts (like reinterpret_cast) from one unrelated type
(content::RenderView*) to another unrelated type
(content::RenderWidget*). The result pointer is invalid,
but it's only used in EXPECT_NE, which would always be satisfied.
Using the correct static cast instead.
The bug was found by Control Flow Integrity check:
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
BUG=chromium:457523,chromium:517544
Review URL: https://codereview.chromium.org/1273183002
Cr-Commit-Position: refs/heads/master@{#342222}
It casts (like reinterpret_cast) from one unrelated type
(content::RenderView*) to another unrelated type
(content::RenderWidget*). The result pointer is invalid,
but it's only used in EXPECT_NE, which would always be satisfied.
Using the correct static cast instead.
The bug was found by Control Flow Integrity check:
https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
BUG=chromium:457523,chromium:517544
Review URL: https://codereview.chromium.org/1273183002
Cr-Commit-Position: refs/heads/master@{#342222}
| content/renderer/render_frame_impl_browsertest.cc | diffblobblamehistory |