Revert of Cleanup: Remove extra EmbeddedWorker layering in the renderer SW code ...
commit25bd6b26cb35a70c0d5b73323cde9e6472ac6334
authorkinuko <kinuko@chromium.org>
Wed, 27 May 2015 13:47:01 +0000 (27 06:47 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 27 May 2015 13:47:41 +0000 (27 13:47 +0000)
tree60c1640b410d74b727d583918e0e19aa56986255
parent5a9a71f25e745357a0512acafa0a9b5346a536a9
Revert of Cleanup: Remove extra EmbeddedWorker layering in the renderer SW code (patchset #5 id:140001 of https://codereview.chromium.org/1136323003/)

Reason for revert:
* WebString should not be directly passed to base::Bind for cross-thread posting
* Caused crash in a layout test: https://crbug.com/492625

Original issue's description:
> Cleanup: Remove extra EmbeddedWorker layering in the renderer SW code
>
> Mechanical changes only:
> - Combine ServiceWorkerScriptContext and EmbeddedWorkerContextClient,
>   renaming it to ServiceWorkerContextClient
> - Rename EmbeddedWorkerContextMessageFilter to ServiceWorkerContextMessageFilter
>
> ServiceWorker/EmbeddedWorker separation in the renderer side
> is currently awkwardly done and require a lot of extra methods
> forwarding between the two classes, looking at the current status
> probably we could combine them.
>
> This leaves all IPC messages and browser-side code as is, at least
> for now.
>
> We could do similar cleanups for those areas too, but currently
> I'm not really motivated to do further cleanups as they don't
> seem causing much extra overhead in our productivity etc.
> (Code-health wise we could probably do better, if anyone's
> motivated to make further cleanups they're welcome)
>
> BUG=491039
> TEST=existing tests
>
> Committed: https://crrev.com/29882b428437d2c70c2950c4699dc9277f7daa61
> Cr-Commit-Position: refs/heads/master@{#331533}

TBR=falken@chromium.org,serviceworker-reviews@chromium.org,avi@chromium.org,hiroshige@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=491039

Review URL: https://codereview.chromium.org/1159933002

Cr-Commit-Position: refs/heads/master@{#331567}
12 files changed:
content/content_renderer.gypi
content/renderer/cache_storage/cache_storage_dispatcher.h
content/renderer/render_thread_impl.cc
content/renderer/service_worker/embedded_worker_context_client.cc [new file with mode: 0644]
content/renderer/service_worker/embedded_worker_context_client.h [new file with mode: 0644]
content/renderer/service_worker/embedded_worker_context_message_filter.cc [new file with mode: 0644]
content/renderer/service_worker/embedded_worker_context_message_filter.h [moved from content/renderer/service_worker/service_worker_context_message_filter.h with 55% similarity]
content/renderer/service_worker/embedded_worker_dispatcher.cc
content/renderer/service_worker/service_worker_context_client.h [deleted file]
content/renderer/service_worker/service_worker_context_message_filter.cc [deleted file]
content/renderer/service_worker/service_worker_script_context.cc [moved from content/renderer/service_worker/service_worker_context_client.cc with 53% similarity]
content/renderer/service_worker/service_worker_script_context.h [new file with mode: 0644]