| commit | 283b2b78f1251125d66b2e99020bc19038127bd3 | |
| author | mgiuca <mgiuca@chromium.org> | |
| Fri, 12 Jun 2015 01:39:46 +0000 (11 18:39 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 12 Jun 2015 01:40:16 +0000 (12 01:40 +0000) | ||
| tree | 0a7610f3e4bfabdb1e7393bc142ed14352deac73 | treesnapshot (tar.gz zip) |
| parent | 4601460b71004bbc068b7c8bc31535788830af8a | commitdiff |
RenderTextHarfBuzz no longer ignores its specified text direction.
The method RenderText::SetDirectionalityMode is supposed to allow the
client to override the default directionality mode (getting the
directionality from the text). However, a bug in BiDiLineIterator means
that it is largely ignored (in the majority of cases, it will use the
directionality of the text regardless).
Fixed BiDiLineIterator to honour the supplied direction.
This should have almost no noticeable effect, as almost all text fields
use the default directionality mode anyway.
BUG=496023,495933
Review URL: https://codereview.chromium.org/1153603004
Cr-Commit-Position: refs/heads/master@{#334106}
The method RenderText::SetDirectionalityMode is supposed to allow the
client to override the default directionality mode (getting the
directionality from the text). However, a bug in BiDiLineIterator means
that it is largely ignored (in the majority of cases, it will use the
directionality of the text regardless).
Fixed BiDiLineIterator to honour the supplied direction.
This should have almost no noticeable effect, as almost all text fields
use the default directionality mode anyway.
BUG=496023,495933
Review URL: https://codereview.chromium.org/1153603004
Cr-Commit-Position: refs/heads/master@{#334106}