| commit | 29d88220e88d21deaf6856b7ded300fa06ab94d3 | |
| author | morrita <morrita@chromium.org> | |
| Tue, 24 Mar 2015 23:52:26 +0000 (24 16:52 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 24 Mar 2015 23:53:29 +0000 (24 23:53 +0000) | ||
| tree | 7079dc17fc8d29949d0c97dd441600b3a5345eff | treesnapshot (tar.gz zip) |
| parent | 1d5a4c807e011a38ec9a2aa84ce66c1cbfe52be1 | commitdiff |
ChannelMojo: Let MessagePipeReader wait "peer closed" signal as well.
This CL adds MOJO_SIGNAL_PEER_CLOSED for the MessagePipeReader's
waiting bits. Without this, PRECONDITION_FAILED error can be notified
at the end of the channel lifetime, and the browser process misinterprets
it as a renderer crash, which results sadface screen.
This rarely happens and is reproduced only with some underpowered CPU
with excessive pressure. So we cannot have any reliable test.
BUG=466814
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/1023043002
Cr-Commit-Position: refs/heads/master@{#322094}
This CL adds MOJO_SIGNAL_PEER_CLOSED for the MessagePipeReader's
waiting bits. Without this, PRECONDITION_FAILED error can be notified
at the end of the channel lifetime, and the browser process misinterprets
it as a renderer crash, which results sadface screen.
This rarely happens and is reproduced only with some underpowered CPU
with excessive pressure. So we cannot have any reliable test.
BUG=466814
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/1023043002
Cr-Commit-Position: refs/heads/master@{#322094}
| ipc/mojo/ipc_message_pipe_reader.cc | diffblobblamehistory |