| commit | 2a1dd1c63c6e26f53120b4362dcaa8b8a9e830ae | |
| author | maxbogue <maxbogue@chromium.org> | |
| Thu, 26 Feb 2015 06:10:50 +0000 (25 22:10 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 26 Feb 2015 06:11:42 +0000 (26 06:11 +0000) | ||
| tree | 68cb9617b037ca74ed355e991d5adf97dfa72656 | treesnapshot (tar.gz zip) |
| parent | ea328be16b456a4bd79a16579a3105858b8421d5 | commitdiff |
Rewrite AndroidSyncSettings to be significantly simpler.
The public methods no longer take an Account as a parameter.
Instead, when the account changes, updateAccount() is called
by ChromeSigninController. This removes the need for all of
the "didUpdate" logic.
Instead, updateCachedSettings() is called only when the
Android settings are changed or the account is changed.
CachedAccountSettings has been removed entirely. A separate
class is not necessary to cache three boolean values (which
it was already only handling two of!)
Review URL: https://codereview.chromium.org/879533004
Cr-Commit-Position: refs/heads/master@{#318196}
The public methods no longer take an Account as a parameter.
Instead, when the account changes, updateAccount() is called
by ChromeSigninController. This removes the need for all of
the "didUpdate" logic.
Instead, updateCachedSettings() is called only when the
Android settings are changed or the account is changed.
CachedAccountSettings has been removed entirely. A separate
class is not necessary to cache three boolean values (which
it was already only handling two of!)
Review URL: https://codereview.chromium.org/879533004
Cr-Commit-Position: refs/heads/master@{#318196}