| commit | 3050bfd98f9e5f185b56c95086a908c89049c759 | |
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 11 Jul 2014 03:54:53 +0000 (11 03:54 +0000) | ||
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 11 Jul 2014 03:54:53 +0000 (11 03:54 +0000) | ||
| tree | 05c200b9734d4cc8f1186860eca78054a423182a | treesnapshot (tar.gz zip) |
| parent | 78d059fcec2f700bf149658a59a05b9a5ca24b83 | commitdiff |
Lots of random cleanups, mostly for native_theme_win.cc:
* Rename "max state" value to "num states" so it sounds less like it's the
largest valid state
* Shorten/simplify code
* Reduce indenting
* No else after return
* Use scoping objects where possible
* Return directly out of switches where possible
* Don't handle DCHECK failure
* Omit NOTREACHED messages (not necessary in tracking down bugs)
* "const" goes on same line as last function arg
* Order "disabled/hovered/normal/pressed" cases the same way every time
* Fix spelling errors
* Eliminate unnecessary {}s
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/377423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282533 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "max state" value to "num states" so it sounds less like it's the
largest valid state
* Shorten/simplify code
* Reduce indenting
* No else after return
* Use scoping objects where possible
* Return directly out of switches where possible
* Don't handle DCHECK failure
* Omit NOTREACHED messages (not necessary in tracking down bugs)
* "const" goes on same line as last function arg
* Order "disabled/hovered/normal/pressed" cases the same way every time
* Fix spelling errors
* Eliminate unnecessary {}s
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/377423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282533 0039d316-1c4b-4281-b951-d872f2087c98