| commit | 34eae4e6bff7377ab7c3e05b915dc87761eee82b | |
| author | jam <jam@chromium.org> | |
| Tue, 25 Aug 2015 20:59:04 +0000 (25 13:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 25 Aug 2015 20:59:37 +0000 (25 20:59 +0000) | ||
| tree | 23ab52459c4a4d0de8f7d0890b0d10a03f0c2597 | treesnapshot (tar.gz zip) |
| parent | 48727cfe4cc0a8d6ec48c37bf84b1b530cb7b9a7 | commitdiff |
Don't create a launcher process when launching a child process in multiprocess unittests.
When using MultiProcessTest, we launch a child process with --test-child-process switch. Currently, after the base test launcher code was added, we were actually creating two processes. The first would be a test launcher process, and then that would create the child process. This is unnecessary (since the outer test launcher is enforcing timeouts) and also makes debugging harder (because the inner test launcher times out and kills the child process when debugging it).
Review URL: https://codereview.chromium.org/1313163002
Cr-Commit-Position: refs/heads/master@{#345431}
When using MultiProcessTest, we launch a child process with --test-child-process switch. Currently, after the base test launcher code was added, we were actually creating two processes. The first would be a test launcher process, and then that would create the child process. This is unnecessary (since the outer test launcher is enforcing timeouts) and also makes debugging harder (because the inner test launcher times out and kills the child process when debugging it).
Review URL: https://codereview.chromium.org/1313163002
Cr-Commit-Position: refs/heads/master@{#345431}
| base/test/launcher/unit_test_launcher.cc | diffblobblamehistory |