| commit | 35b4727d5f441d988ac42f0881355933107d7b8a | |
| author | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 12 Feb 2014 17:57:34 +0000 (12 17:57 +0000) | ||
| committer | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 12 Feb 2014 17:57:34 +0000 (12 17:57 +0000) | ||
| tree | 700abe351d90f6f061758574ee7fc13fd3e66dab | treesnapshot (tar.gz zip) |
| parent | c1e52c8b1e50dc2061e0cf95906ca6bb5f1ba619 | commitdiff |
Fix linking of stale resources in setup.exe.
The lesson is: don't include .rc files from other .rc files. The
toolchain doesn't track dependencies through .rc inclusion, so .res
files don't get rebuilt and the final binary ends up with stale
resources.
BUG=334879
Review URL: https://codereview.chromium.org/157703009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250754 0039d316-1c4b-4281-b951-d872f2087c98
The lesson is: don't include .rc files from other .rc files. The
toolchain doesn't track dependencies through .rc inclusion, so .res
files don't get rebuilt and the final binary ends up with stale
resources.
BUG=334879
Review URL: https://codereview.chromium.org/157703009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250754 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/chrome_installer.gypi | diffblobblamehistory | |
| chrome/installer/setup/setup.rc | diffblobblamehistory | |
| chrome/installer/setup/setup_exe_version.rc.version | diffblobblamehistory |