| commit | 3b4ba221657f6b27e2156818bc445c885d87fc0e | |
| author | pneubeck <pneubeck@chromium.org> | |
| Fri, 19 Sep 2014 11:05:49 +0000 (19 04:05 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 19 Sep 2014 11:06:01 +0000 (19 11:06 +0000) | ||
| tree | 82681a911c2a9a3692cfc3e51142e5e31b8842da | treesnapshot (tar.gz zip) |
| parent | c6ccc77dc9c080d83e400dc12205bb805a25ac71 | commitdiff |
Make ONCCertificateImporter async.
This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
Now, the import itself is asychronous and calls back on completion.
While there, this also removes the GMock of the importer.
This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925
refs/heads/master@{#295534}
with the fixed destruction order in ONCCertificateImporterImplTest.
The fix was reviewed in
https://codereview.chromium.org/589443002/
TBR=eroman@chromium.org
BUG=413219
Review URL: https://codereview.chromium.org/582413002
Cr-Commit-Position: refs/heads/master@{#295687}
This prepares for the new CertDatabase keyed service, which will have stricter threading restrictions. https://codereview.chromium.org/419013003/
Before, ONCCertificateImporter accessed the NSSCertDatabase from the UI thread and blocked on certificate store operations.
Now, the import itself is asychronous and calls back on completion.
While there, this also removes the GMock of the importer.
This is a reland of f08303014b165f6013fe33198cd798ebd9a4e925
refs/heads/master@{#295534}
with the fixed destruction order in ONCCertificateImporterImplTest.
The fix was reviewed in
https://codereview.chromium.org/589443002/
TBR=eroman@chromium.org
BUG=413219
Review URL: https://codereview.chromium.org/582413002
Cr-Commit-Position: refs/heads/master@{#295687}