| commit | 3ba111306b6a43f51c4dfb97536b8d77eb523d69 | |
| author | estark <estark@chromium.org> | |
| Fri, 10 Apr 2015 01:38:33 +0000 (9 18:38 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 10 Apr 2015 01:39:04 +0000 (10 01:39 +0000) | ||
| tree | 9ac68e985bbc2dd4470dfbb3e7851f23c0f2f761 | treesnapshot (tar.gz zip) |
| parent | 55c2f2365e41a170f37ed56d13ced4ef054abffa | commitdiff |
Add certificate report interface to break ssl->safe_browsing dependency
Instead of passing a SafeBrowsingUIManager through for SSLBlockingPage
to use for invalid certificate reports, //chrome/browser/ssl now
declares a pure virtual interface. ChromeContentBrowserClient uses the
safe browsing service to implement this interface and passes it through
SSLErrorHandler for SSLBlockingPage to use. This breaks the
ssl -> safe_browsing dependency.
BUG=470415
Review URL: https://codereview.chromium.org/1043083002
Cr-Commit-Position: refs/heads/master@{#324567}
Instead of passing a SafeBrowsingUIManager through for SSLBlockingPage
to use for invalid certificate reports, //chrome/browser/ssl now
declares a pure virtual interface. ChromeContentBrowserClient uses the
safe browsing service to implement this interface and passes it through
SSLErrorHandler for SSLBlockingPage to use. This breaks the
ssl -> safe_browsing dependency.
BUG=470415
Review URL: https://codereview.chromium.org/1043083002
Cr-Commit-Position: refs/heads/master@{#324567}