| commit | 3cb0ffe5d45628e02aea032e4edc89e08a1ecac5 | |
| author | sky <sky@chromium.org> | |
| Wed, 5 Aug 2015 23:21:13 +0000 (5 16:21 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 5 Aug 2015 23:21:45 +0000 (5 23:21 +0000) | ||
| tree | 3a15eee81c3d03e3a51b92aab9f546aa97ca5643 | treesnapshot (tar.gz zip) |
| parent | b3dcc8f78eafcc0c8a5ae0cad0c8c79ee73b7c37 | commitdiff |
Adds notification when a viewmanagerclient is unembedded
Currently clients see OnViewDeleted(), which means the client has no
way to discern between a deletion and another app getting
embedded.
This is necessary so that html_viewer knows when it needs to swap what is a local frame to a remote frame. Currently html viewer sees the view as being destroyed and deletes the frame. If another frame is being embedded then deleting the frame isn't the right thing, instead the frame needs to be converted to remote. Adding OnUnembed() allows html viewer to detect the reuse case.
BUG=479172,490221
TEST=covered by tests
R=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/1276723003
Cr-Commit-Position: refs/heads/master@{#342004}
Currently clients see OnViewDeleted(), which means the client has no
way to discern between a deletion and another app getting
embedded.
This is necessary so that html_viewer knows when it needs to swap what is a local frame to a remote frame. Currently html viewer sees the view as being destroyed and deletes the frame. If another frame is being embedded then deleting the frame isn't the right thing, instead the frame needs to be converted to remote. Adding OnUnembed() allows html viewer to detect the reuse case.
BUG=479172,490221
TEST=covered by tests
R=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/1276723003
Cr-Commit-Position: refs/heads/master@{#342004}