| commit | 3e47c6dbf899d98f38db45f4cc766bd6a2eca5cd | |
| author | toyoshim <toyoshim@chromium.org> | |
| Tue, 7 Apr 2015 11:15:44 +0000 (7 04:15 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 7 Apr 2015 11:16:04 +0000 (7 11:16 +0000) | ||
| tree | d889deb290e87d97ac9a213f91d557660208618b | treesnapshot (tar.gz zip) |
| parent | 61b74f33ea37daf09b4e42a8601e97d16911c99b | commitdiff |
Web MIDI: Improve device change monitornig on Windows
Current implementation monitors DBT_DEVICEARRIVAL mesage, but that
is not a right message to monitor device changes since actual device
list that OS holds will be updated a little later. Instead, monitor
DBT_DEVNODES_CHANGES that is delivered after the list being updated.
In Chrome, SystemMessageWindowWin invokes base::SystemMonitor's observer
with DEVTYPE_UNKNOWN for DBT_DEVNODES_CHANGED, and the SystemMonitor
provides a way to observe the event on the registered thread.
Using the monitor must be the right implementation.
BUG=472980
Review URL: https://codereview.chromium.org/1056333002
Cr-Commit-Position: refs/heads/master@{#324031}
Current implementation monitors DBT_DEVICEARRIVAL mesage, but that
is not a right message to monitor device changes since actual device
list that OS holds will be updated a little later. Instead, monitor
DBT_DEVNODES_CHANGES that is delivered after the list being updated.
In Chrome, SystemMessageWindowWin invokes base::SystemMonitor's observer
with DEVTYPE_UNKNOWN for DBT_DEVNODES_CHANGED, and the SystemMonitor
provides a way to observe the event on the registered thread.
Using the monitor must be the right implementation.
BUG=472980
Review URL: https://codereview.chromium.org/1056333002
Cr-Commit-Position: refs/heads/master@{#324031}
| media/midi/midi_manager_unittest.cc | diffblobblamehistory | |
| media/midi/midi_manager_win.cc | diffblobblamehistory |