| commit | 40dbafab4cfef214d7a4bae22c8d698936ed6f5f | |
| author | zea <zea@chromium.org> | |
| Tue, 9 Sep 2014 00:54:35 +0000 (8 17:54 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 9 Sep 2014 00:57:39 +0000 (9 00:57 +0000) | ||
| tree | cf3cd0eed33249fe863452aa886799c19b9eb687 | treesnapshot (tar.gz zip) |
| parent | 584002d1c89e79223f8bf5f973294b96bdfa15ab | commitdiff |
Fix use-after-free in HDDDTC shutdown
We were trying to unregister the HistoryDeleteDirective DTC at shutdown, but
the DTC shutdown happens as part of the ProfileSyncService shutdown, and is
destroyed after the observers_ object is destroyed. As such, there's no need
to remove the observer.
This patch also unreverts 6513171d7473b9eb60e1bf16369cf893daa33a07
Original codereview at https://codereview.chromium.org/534733002
BUG=409965 368834
Review URL: https://codereview.chromium.org/535683002
Cr-Commit-Position: refs/heads/master@{#293824}
We were trying to unregister the HistoryDeleteDirective DTC at shutdown, but
the DTC shutdown happens as part of the ProfileSyncService shutdown, and is
destroyed after the observers_ object is destroyed. As such, there's no need
to remove the observer.
This patch also unreverts 6513171d7473b9eb60e1bf16369cf893daa33a07
Original codereview at https://codereview.chromium.org/534733002
BUG=409965 368834
Review URL: https://codereview.chromium.org/535683002
Cr-Commit-Position: refs/heads/master@{#293824}
22 files changed: