| commit | 410247e15c4cb03a8533a01509477759ebc3ad1d | |
| author | huangs@chromium.org <huangs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 28 May 2013 18:31:20 +0000 (28 18:31 +0000) | ||
| committer | huangs@chromium.org <huangs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 28 May 2013 18:31:20 +0000 (28 18:31 +0000) | ||
| tree | 8c0ff34e76fb4e3a615758f27051131c74e43bd5 | treesnapshot (tar.gz zip) |
| parent | 4d9d3bc75c7e6598f8c3b3341f8b9d05afcb821d | commitdiff |
Removing deprecated DCHECK's that require App Launcher to be user-level only.
With Chrome / App Launcher unification, the App Launcher can be installed at system-level. Old DCHECK's to enforce otherwise are creating bogus failures, and should be removed.
This bug is triggered by https://chromiumcodereview.appspot.com/14711006/ , which adds "shadow" App Launcher Clients/ClientState keys to support 7DA tracking for App Launcher. Unfortunately, these keys are read, and are interpreted as the presence of App Launcher (thus triggering DCHECK).
A separate issue is that installation_validator complains about missing information in the "shadow" registry key. This is less urgent, and hence not part of this CL.
BUG=243432
Review URL: https://chromiumcodereview.appspot.com/15915003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202605 0039d316-1c4b-4281-b951-d872f2087c98
With Chrome / App Launcher unification, the App Launcher can be installed at system-level. Old DCHECK's to enforce otherwise are creating bogus failures, and should be removed.
This bug is triggered by https://chromiumcodereview.appspot.com/14711006/ , which adds "shadow" App Launcher Clients/ClientState keys to support 7DA tracking for App Launcher. Unfortunately, these keys are read, and are interpreted as the presence of App Launcher (thus triggering DCHECK).
A separate issue is that installation_validator complains about missing information in the "shadow" registry key. This is less urgent, and hence not part of this CL.
BUG=243432
Review URL: https://chromiumcodereview.appspot.com/15915003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202605 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/installer/setup/uninstall.cc | diffblobblamehistory | |
| chrome/installer/util/installation_validator.cc | diffblobblamehistory |