webapps: allow callers of icon downloader/selector to specify a minimum size
commit45a03c70176668cceedede5bd203b4c80b7c95cc
authorlalitm <lalitm@google.com>
Wed, 16 Sep 2015 13:00:43 +0000 (16 06:00 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 16 Sep 2015 13:01:35 +0000 (16 13:01 +0000)
tree0fc030b697db02f00416cbadad2a3c50951165ee
parent648bccc6d73e18fcfe57e6ff62e239092178aa89
webapps: allow callers of icon downloader/selector to specify a minimum size

Since we now want to allow splash screen images down to 48dp but still want
to keep the one density bucket requirement below for home screen icons, the
callers should be able to specify the minimum icon size that they want
selected/downloaded.

Since it was going to be a ton of boilerplate to add this in the same way as
ideal_splash_icon_size_in_dp was added, also refactor the way icon sizes are
stored to reduce the boiler plate.

As a plus, AppBanner on desktop also gets minimum icon sizes correctly now
which was present as a TODO.

BUG=508627

Review URL: https://codereview.chromium.org/1308533006

Cr-Commit-Position: refs/heads/master@{#349106}
27 files changed:
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java
chrome/browser/android/banners/app_banner_data_fetcher_android.cc
chrome/browser/android/banners/app_banner_data_fetcher_android.h
chrome/browser/android/banners/app_banner_manager_android.cc
chrome/browser/android/banners/app_banner_manager_android.h
chrome/browser/android/shortcut_helper.cc
chrome/browser/android/shortcut_helper.h
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h
chrome/browser/banners/app_banner_data_fetcher.cc
chrome/browser/banners/app_banner_data_fetcher.h
chrome/browser/banners/app_banner_data_fetcher_browsertest.cc
chrome/browser/banners/app_banner_data_fetcher_desktop.cc
chrome/browser/banners/app_banner_data_fetcher_desktop.h
chrome/browser/banners/app_banner_manager.cc
chrome/browser/banners/app_banner_manager.h
chrome/browser/banners/app_banner_manager_desktop.cc
chrome/browser/banners/app_banner_manager_desktop.h
chrome/browser/manifest/manifest_icon_downloader.cc
chrome/browser/manifest/manifest_icon_downloader.h
chrome/browser/manifest/manifest_icon_selector.cc
chrome/browser/manifest/manifest_icon_selector.h
chrome/browser/manifest/manifest_icon_selector_unittest.cc