Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..."
commit49ec031c22cdccd490e5ea328c2c01a98e793e21
authorzmo@chromium.org <zmo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Tue, 18 Mar 2014 02:39:03 +0000 (18 02:39 +0000)
committerzmo@chromium.org <zmo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Tue, 18 Mar 2014 02:39:03 +0000 (18 02:39 +0000)
tree6995a795f122aa0abc6d71befb21149ed9232877
parentc27ded48173d1cee6bed4e1f82d29852607cd9e9
Revert 257577 "Revert 257562 "Base: Make base::File use ScopedFD..."

Reland this: turns out not responsible.

> Revert 257562 "Base: Make base::File use ScopedFD on POSIX."
>
> Might caused a bunch of layout test failures, at least on Linux
>
> fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html,
> fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html,
> fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html,
> fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
>
> > Base: Make base::File use ScopedFD on POSIX.
> >
> > Now that ScopedFD lives outside of file_util, File can use it to remove manual
> > lifetime management.
> >
> > This also standarizes the behavior on Close failures for all platforms.
> >
> > BUG=none
> >
> > Review URL: https://codereview.chromium.org/201083002
>
> TBR=rvargas@chromium.org
>
> Review URL: https://codereview.chromium.org/202583005

TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/202493007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257581 0039d316-1c4b-4281-b951-d872f2087c98
base/files/file.cc
base/files/file.h
base/files/file_posix.cc
base/files/file_win.cc