| commit | 4a1650ffd40fb4b042d2004b938f2442ccafcec9 | |
| author | fsamuel <fsamuel@chromium.org> | |
| Fri, 23 Jan 2015 21:57:49 +0000 (23 13:57 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 23 Jan 2015 21:58:35 +0000 (23 21:58 +0000) | ||
| tree | 10f82dfae478a71228a907b3efb5aac0fa361b99 | treesnapshot (tar.gz zip) |
| parent | d432c0eb6c8f6fd27b6d210701df47317d480e05 | commitdiff |
<webview>: Reuse GuestViewBase::HandleKeyboardEvent code.
<webview> has its own implementation of HandleKeyboardEvent that deals with back/forward keys
and so on but for keys it doesn't know how to handle, it should pass them along as other
GuestViews do.
This CL also moves WebContentsObserver and WebContentsDelegate overrides in GuestViewBase from private to protected.
BUG=none
Review URL: https://codereview.chromium.org/869193004
Cr-Commit-Position: refs/heads/master@{#312938}
<webview> has its own implementation of HandleKeyboardEvent that deals with back/forward keys
and so on but for keys it doesn't know how to handle, it should pass them along as other
GuestViews do.
This CL also moves WebContentsObserver and WebContentsDelegate overrides in GuestViewBase from private to protected.
BUG=none
Review URL: https://codereview.chromium.org/869193004
Cr-Commit-Position: refs/heads/master@{#312938}
| extensions/browser/guest_view/guest_view_base.h | diffblobblamehistory | |
| extensions/browser/guest_view/web_view/web_view_guest.cc | diffblobblamehistory |