Revert of Update smoothness_controller to use results.AddValue(...) (https://coderevi...
commit4d3217808680a9b5e15f3067eae2b472d526ca8f
authordgrogan@chromium.org <dgrogan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 9 Jul 2014 23:20:57 +0000 (9 23:20 +0000)
committerdgrogan@chromium.org <dgrogan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Wed, 9 Jul 2014 23:20:57 +0000 (9 23:20 +0000)
treede07fa94768103c2538463823523f05490aa7fd6
parentfbcf36abadeb1f8e77890c6892f9acf15d44f1ed
Revert of Update smoothness_controller to use results.AddValue(...) (https://codereview.chromium.org/380803002/)

Reason for revert:
Possibly caused Android Tests failures. See http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14520/steps/telemetry_perf_unittests/logs/stdio

E.g.
Traceback (most recent call last):
  _RunPage at tools/telemetry/telemetry/page/page_runner.py:534
    test.RunPage(page, page_state.tab, results)
  RunPage at tools/telemetry/telemetry/page/page_test.py:247
    self.ValidatePage(page, tab, results)
  ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:60
    self.MeasurePage(page, tab, results)
  MeasurePage at tools/perf/measurements/smoothness.py:36
    self._smoothness_controller.AddResults(tab, results)
  AddResults at tools/perf/measurements/smoothness_controller.py:100
    results.current_page, r.name, r.unit, r.value))
  __init__ at tools/telemetry/telemetry/value/scalar.py:19
    assert isinstance(value, numbers.Number)
AssertionError

Original issue's description:
> Update smoothness_controller to use results.AddValue(...)
>
> BUG=391943
> TBR=nduca@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282131

TBR=nduca@chromium.org,nednguyen@google.com
NOTREECHECKS=true
NOTRY=true
BUG=391943

Review URL: https://codereview.chromium.org/382673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282170 0039d316-1c4b-4281-b951-d872f2087c98
tools/perf/measurements/smoothness_controller.py