| commit | 50391a6730c1d7cdfd668ff85309c4a1514e6870 | |
| author | ccameron@chromium.org <ccameron@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 31 Jul 2014 00:19:24 +0000 (31 00:19 +0000) | ||
| committer | ccameron@chromium.org <ccameron@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 31 Jul 2014 00:19:24 +0000 (31 00:19 +0000) | ||
| tree | 52ae736bb021c88fc6a1e791e10682cd2a44be1d | treesnapshot (tar.gz zip) |
| parent | 52fe82e7ea2aa1ae72116f96c7a235751572d185 | commitdiff |
Mac: Don't use a dummy NSView as a gfx::AcceleratedWidget
Originally, each ui::Compositor did actually render into a NSView
on Mac, at which point it did make sense to use a NSView as the
gfx::AcceleratedWidget for the ui::Compositor. This has since
been changed due to stability and memory and performance issues.
Now, make the gfx::AcceleratedWidget be a key in a map that is
used to look up the corresponding BrowserCompositorViewMacInternals.
There is a chance that lifetime issues related to the NSView scheme
were causing crashes by sending messages to dead objects.
BUG=394051
Review URL: https://codereview.chromium.org/420143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286652 0039d316-1c4b-4281-b951-d872f2087c98
Originally, each ui::Compositor did actually render into a NSView
on Mac, at which point it did make sense to use a NSView as the
gfx::AcceleratedWidget for the ui::Compositor. This has since
been changed due to stability and memory and performance issues.
Now, make the gfx::AcceleratedWidget be a key in a map that is
used to look up the corresponding BrowserCompositorViewMacInternals.
There is a chance that lifetime issues related to the NSView scheme
were causing crashes by sending messages to dead objects.
BUG=394051
Review URL: https://codereview.chromium.org/420143004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286652 0039d316-1c4b-4281-b951-d872f2087c98