Make Linker.isUsed() static, and clean up the fallout.
commit51958d6ded60cc90a9814220c55db2a8dce0d181
authorsimonb <simonb@chromium.org>
Tue, 1 Sep 2015 19:04:42 +0000 (1 12:04 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 1 Sep 2015 19:05:17 +0000 (1 19:05 +0000)
treed68070f7970dfb0765d77a7f30730b3d481288aa
parenta07f35f98c09b87e4702b52ef6e4cba21bbb9d2f
Make Linker.isUsed() static, and clean up the fallout.

Make Linker.isUsed() static, so that client code no longer needs to
instantiate a Linker simply to find out that one is not used.
Clean up call sites to avoid nugatory instantiations.

Fix a race that occurred in testing code (prevalent on arm64 but
unseen on arm32) because of the previous non-static Linker.isUsed(),
add Linker testing convenience setup function, and clean up client
code that must configure a Linker for testing if required.

Enable testing for arm64, and check that it now works cleanly.

Tidy up a few method names and string formatting. Add a previously
missing synchronized(singletonLock).

BUG=385553

Review URL: https://codereview.chromium.org/1314823003

Cr-Commit-Position: refs/heads/master@{#346700}
base/android/java/src/org/chromium/base/library_loader/LegacyLinker.java
base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java
base/android/java/src/org/chromium/base/library_loader/Linker.java
base/android/java/src/org/chromium/base/library_loader/ModernLinker.java
content/content_tests.gypi
content/public/android/java/src/org/chromium/content/app/ChildProcessService.java
content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
content/shell/android/BUILD.gn
content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc
content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestActivity.java
content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/LinkerTests.java