| commit | 54e715bb552b75fbd91b7cec7be9d432135d9fd8 | |
| author | hendrikw <hendrikw@chromium.org> | |
| Sat, 13 Dec 2014 04:46:37 +0000 (12 20:46 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Sat, 13 Dec 2014 04:47:14 +0000 (13 04:47 +0000) | ||
| tree | 8d10b7b5aa9d20140970b77df0d6746d3b9d9fd6 | treesnapshot (tar.gz zip) |
| parent | 77e99db27a00f0efdc75a91c4b7a04518aff55a2 | commitdiff |
ui: Bubble fix
woops, when I was testing this, I hadn't noticed the mistake because
I was testing over a white background, and the shadow looks exactly
like the bubble in that case.
I had used the wrong color for the shadow color, and as a result I
didn't notice that the shadow was in the wrong spot.
I did a bit more extensive testing, if you have chrome fullscreen on the
left side, and you show the bubble on the right, it does extend to right
screen by 1 pixel. This happened before and after my change.
BUG=435910
Review URL: https://codereview.chromium.org/792243002
Cr-Commit-Position: refs/heads/master@{#308252}
woops, when I was testing this, I hadn't noticed the mistake because
I was testing over a white background, and the shadow looks exactly
like the bubble in that case.
I had used the wrong color for the shadow color, and as a result I
didn't notice that the shadow was in the wrong spot.
I did a bit more extensive testing, if you have chrome fullscreen on the
left side, and you show the bubble on the right, it does extend to right
screen by 1 pixel. This happened before and after my change.
BUG=435910
Review URL: https://codereview.chromium.org/792243002
Cr-Commit-Position: refs/heads/master@{#308252}
| chrome/browser/ui/views/status_bubble_views.cc | diffblobblamehistory |