| commit | 5886fc8beb1ae5714f25a8bb1c76a42bfe88272c | |
| author | kkimlabs <kkimlabs@chromium.org> | |
| Mon, 10 Aug 2015 22:52:21 +0000 (10 15:52 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 10 Aug 2015 22:53:00 +0000 (10 22:53 +0000) | ||
| tree | 307cdf726c28b8d9e0b356b43aa08a48cbe3252b | treesnapshot (tar.gz zip) |
| parent | e04e538e2caf8a5bcaa0c55b05b09010a5ea1676 | commitdiff |
[Android] Make enhanced bookmark editing UI more straightforward.
- We didn't save when a dialog is dismissed by tapping outside on
tablet, which can be also confusing as there is no save UI concept.
So save onPause always.
- User should know when we won't save what user typed if it fails
validation. But blocking dialog exit is too invasive, and sometimes
we don't have a control (tapping outside on tablet.) So show warning
as user types.
BUG=510253
Review URL: https://codereview.chromium.org/1230313009
Cr-Commit-Position: refs/heads/master@{#342719}
- We didn't save when a dialog is dismissed by tapping outside on
tablet, which can be also confusing as there is no save UI concept.
So save onPause always.
- User should know when we won't save what user typed if it fails
validation. But blocking dialog exit is too invasive, and sometimes
we don't have a control (tapping outside on tablet.) So show warning
as user types.
BUG=510253
Review URL: https://codereview.chromium.org/1230313009
Cr-Commit-Position: refs/heads/master@{#342719}