| commit | 5a02c6dd2c36add15e740f9f1a48bef8c415b677 | |
| author | tbansal <tbansal@chromium.org> | |
| Tue, 8 Sep 2015 17:48:13 +0000 (8 10:48 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 8 Sep 2015 17:48:46 +0000 (8 17:48 +0000) | ||
| tree | 57dd75839f91629278290049b4461a7ddbf9a298 | treesnapshot (tar.gz zip) |
| parent | f674dbcc34d73be958cb9a378b3154a7d8cd334b | commitdiff |
Revert of Fix cronet crash on calling IsDataReductionProxyEnabled (patchset #4 id:60001 of https://codereview.chromium.org/1308923003/ )
Reason for revert:
This does not help in fixing the cronet crash. Also, it is
calling data_reduction_proxy_service->GetWeakPtr() after
data_reduction_proxy_service has been Passed. After the
ownership is passed, data_reduction_proxy_service is
null.
Original issue's description:
> Fix cronet crash on calling IsDataReductionProxyEnabled
>
> BUG=526776
>
> Committed: https://crrev.com/3b63265bd7f9004f215f40b80bb1f506294e7788
> Cr-Commit-Position: refs/heads/master@{#347295}
BUG=528527
Review URL: https://codereview.chromium.org/1304983007
Cr-Commit-Position: refs/heads/master@{#347733}
Reason for revert:
This does not help in fixing the cronet crash. Also, it is
calling data_reduction_proxy_service->GetWeakPtr() after
data_reduction_proxy_service has been Passed. After the
ownership is passed, data_reduction_proxy_service is
null.
Original issue's description:
> Fix cronet crash on calling IsDataReductionProxyEnabled
>
> BUG=526776
>
> Committed: https://crrev.com/3b63265bd7f9004f215f40b80bb1f506294e7788
> Cr-Commit-Position: refs/heads/master@{#347295}
BUG=528527
Review URL: https://codereview.chromium.org/1304983007
Cr-Commit-Position: refs/heads/master@{#347733}
| components/cronet/android/cronet_data_reduction_proxy.cc | diffblobblamehistory |