| commit | 5a83109b2fe5f328635cc297dc6db67518071dda | |
| author | grt <grt@chromium.org> | |
| Tue, 2 Dec 2014 18:40:44 +0000 (2 10:40 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 2 Dec 2014 18:41:30 +0000 (2 18:41 +0000) | ||
| tree | 219a668a2d739b697e21f44a268fcc96afb65baf | treesnapshot (tar.gz zip) |
| parent | 61dcc0bbb1772b614a739a51c4d70b89ff912bed | commitdiff |
Modernize on-demand update checks on Windows.
The code was a bit long in the tooth. Some changes:
- There is now a fairly comprehensive unit test.
- Update checks no longer do a nested Run() of the FILE thread's message
loop. Rather, they return to the main loop while waiting for Google
Update.
- A callback is used to return the results rather than a single-method
listener interface.
- Lifetime management is simpler: the interface can be fire-and-forget
since the caller could specify a null callback.
BUG=424689
Review URL: https://codereview.chromium.org/729273002
Cr-Commit-Position: refs/heads/master@{#306421}
The code was a bit long in the tooth. Some changes:
- There is now a fairly comprehensive unit test.
- Update checks no longer do a nested Run() of the FILE thread's message
loop. Rather, they return to the main loop while waiting for Google
Update.
- A callback is used to return the results rather than a single-method
listener interface.
- Lifetime management is simpler: the interface can be fire-and-forget
since the caller could specify a null callback.
BUG=424689
Review URL: https://codereview.chromium.org/729273002
Cr-Commit-Position: refs/heads/master@{#306421}