| commit | 5d5471bdd49e4f3a1f4d0139532a5a13d2b10055 | |
| author | japhet@chromium.org <japhet@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 4 Apr 2014 22:17:52 +0000 (4 22:17 +0000) | ||
| committer | japhet@chromium.org <japhet@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 4 Apr 2014 22:17:52 +0000 (4 22:17 +0000) | ||
| tree | 324025cd490a3de624ffbe3828a877b781b5445b | treesnapshot (tar.gz zip) |
| parent | b0f8c3ec58186f88846f2f2f36c6dfa431fe8d14 | commitdiff |
De-virtualize RenderViewImpl's commit-time functions
didNavigateWithinPage() is only used by RenderViewTest, which can call directly into RenderFrameImpl::didNavigateWithinPage() to accomplish the same thing.
didCommitProvisionaLoad() should be FrameDidCommitProvisionaLoad() and devirtualized.
This is necessary to allow builds that use -Woverloaded-virtual to successfully compile the next step of moving HistoryController to content/ (https://codereview.chromium.org/217363005/)
BUG=357327
Review URL: https://codereview.chromium.org/224713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261898 0039d316-1c4b-4281-b951-d872f2087c98
didNavigateWithinPage() is only used by RenderViewTest, which can call directly into RenderFrameImpl::didNavigateWithinPage() to accomplish the same thing.
didCommitProvisionaLoad() should be FrameDidCommitProvisionaLoad() and devirtualized.
This is necessary to allow builds that use -Woverloaded-virtual to successfully compile the next step of moving HistoryController to content/ (https://codereview.chromium.org/217363005/)
BUG=357327
Review URL: https://codereview.chromium.org/224713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261898 0039d316-1c4b-4281-b951-d872f2087c98