| commit | 5e028f52618ba56b7d69fa1004732a2deaff9dcd | |
| author | pavely@chromium.org <pavely@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 12 Mar 2014 02:17:04 +0000 (12 02:17 +0000) | ||
| committer | pavely@chromium.org <pavely@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 12 Mar 2014 02:17:04 +0000 (12 02:17 +0000) | ||
| tree | 5debd4a0ec53049766cc55d2607666122d8945ed | treesnapshot (tar.gz zip) |
| parent | 4d99a24d40847d5472b92f9d6b7c67612db23ada | commitdiff |
Assign SyncGlobalError unique MenuItemCommandID
Currently both SyncGlobalError and SigninGlobalError return the same
command Id, this causes DCHECK if both errors are triggered at the same
time.
Additionally clicking on either of menu items is handled by whatever
object was registered with GlobalErrorService first.
Fix is to assign SyncGlobalError different ID.
BUG=344106
R=atwilson@chromium.org,rogerta@chromium.org
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/193613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256403 0039d316-1c4b-4281-b951-d872f2087c98
Currently both SyncGlobalError and SigninGlobalError return the same
command Id, this causes DCHECK if both errors are triggered at the same
time.
Additionally clicking on either of menu items is handled by whatever
object was registered with GlobalErrorService first.
Fix is to assign SyncGlobalError different ID.
BUG=344106
R=atwilson@chromium.org,rogerta@chromium.org
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/193613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256403 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/app/chrome_command_ids.h | diffblobblamehistory | |
| chrome/browser/sync/sync_global_error.cc | diffblobblamehistory |