| commit | 65db145cc63bfef8b2bf9a539cec21a2151639b2 | |
| author | erikchen <erikchen@chromium.org> | |
| Fri, 8 May 2015 01:59:02 +0000 (7 18:59 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 8 May 2015 01:59:30 +0000 (8 01:59 +0000) | ||
| tree | 370fcc481e3c6769613e7b8ae6e58b511a116e34 | treesnapshot (tar.gz zip) |
| parent | fdf00f9b7799fc8cee28e6b4053235cba3c15178 | commitdiff |
Fix a test in text_input_client_mac_unittest.mm.
When Chrome is linked against an OSX 10.9+ SDK, -[NSAttributedString
copy] returns a retained self, rather than a copy.
-[NSMutableAttributedString copy] returns a new object. The test
TextInputClientMacTest.GetSubstring was checking that a new object was
made, but it was passing as an input an NSAttributedString. I changed
the test to use a NSMutableAttributedString as input instead.
BUG=484203
Review URL: https://codereview.chromium.org/1131773002
Cr-Commit-Position: refs/heads/master@{#328903}
When Chrome is linked against an OSX 10.9+ SDK, -[NSAttributedString
copy] returns a retained self, rather than a copy.
-[NSMutableAttributedString copy] returns a new object. The test
TextInputClientMacTest.GetSubstring was checking that a new object was
made, but it was passing as an input an NSAttributedString. I changed
the test to use a NSMutableAttributedString as input instead.
BUG=484203
Review URL: https://codereview.chromium.org/1131773002
Cr-Commit-Position: refs/heads/master@{#328903}
| content/browser/renderer_host/text_input_client_mac_unittest.mm | diffblobblamehistory |