| commit | 684e2e69287965c723281148464332e18c39a2e2 | |
| author | ananta <ananta@chromium.org> | |
| Tue, 18 Nov 2014 21:36:26 +0000 (18 13:36 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 18 Nov 2014 21:37:36 +0000 (18 21:37 +0000) | ||
| tree | c8d3126074a62f09e79da85bd711a15d71079870 | treesnapshot (tar.gz zip) |
| parent | d98f8102de3fe1bf53313a64be3fb7cb17040f6a | commitdiff |
Fix a crasher in Chrome canary on Windows which occurs because of a CHECK firing because of a failure to create a direct write font using the GDI compatible interface from a LOGFONT.
One of the crashing fonts is EuroStyle. The failure returned by DirectWrite from the CreateFontFromLOGFONT call
is font not found.
It is not clear why that failure is being returned. In any case I changed the logic to mimic what skia does. Instead
of going down the GDI compatible route, we find the font in the system font collection exposed by DirectWrite. Failing
to find the font fallsback to to the default system font on the machine.
BUG=434425
Review URL: https://codereview.chromium.org/738913004
Cr-Commit-Position: refs/heads/master@{#304671}
One of the crashing fonts is EuroStyle. The failure returned by DirectWrite from the CreateFontFromLOGFONT call
is font not found.
It is not clear why that failure is being returned. In any case I changed the logic to mimic what skia does. Instead
of going down the GDI compatible route, we find the font in the system font collection exposed by DirectWrite. Failing
to find the font fallsback to to the default system font on the machine.
BUG=434425
Review URL: https://codereview.chromium.org/738913004
Cr-Commit-Position: refs/heads/master@{#304671}
| ui/gfx/platform_font_win.cc | diffblobblamehistory |