Revert of Prepare HistoryQuickProvider for componentization (patchset #5 id:80001...
commit685cea65df5914b6418f4c752bfa77f9857e632a
authorpaulmeyer <paulmeyer@chromium.org>
Wed, 17 Jun 2015 17:05:15 +0000 (17 10:05 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 17 Jun 2015 17:05:54 +0000 (17 17:05 +0000)
tree7c420c75d92242987a5f7eeee16d98c46d899a0c
parentd0330e071050cab7dcebd6e3026e692fdead4b15
Revert of Prepare HistoryQuickProvider for componentization (patchset #5 id:80001 of https://codereview.chromium.org/1183773006/)

Reason for revert:
Speculative revert to fix the Windows unit_test failures.

Original issue's description:
> Prepare HistoryQuickProvider for componentization
>
> - //content- and //chrome-level dependencies are abstracted via the client.
>
> - The crash key for crbug.com/464926 is changed to be defined internally at the
>   two usage points to break the dependency of history_quick_provider.cc on
>   //chrome/common/crash_keys.h. Note that the proper way to do this would be
>   to create an omnibox_crash_keys.{h,cc} file defining this constant and have
>   //chrome/common/crash_keys.cc depend on that. However, that would require
>   dividing //components/omnibox into browser/ and common/ subdirectories so
>   that //chrome/common could depend on //components/omnibox/common.  As (a) at
>   some point crbug.com/464926 will be closed and this code will be removed, and
>   (b) there is no other omnibox-related code that will need to be referenced by
>   //chrome/common in the future, doing a big restructuring of
>   //components/omnibox would just be churn for very little gain.
>
> BUG=371538
>
> Committed: https://crrev.com/9c6d21fa07a07e59c883bf2fa5ed3ed32d5665d0
> Cr-Commit-Position: refs/heads/master@{#334809}

TBR=pkasting@chromium.org,rsesek@chromium.org,blundell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=371538

Review URL: https://codereview.chromium.org/1184963005

Cr-Commit-Position: refs/heads/master@{#334861}
chrome/browser/autocomplete/autocomplete_controller.cc
chrome/browser/autocomplete/history_quick_provider.cc
chrome/browser/autocomplete/history_quick_provider.h
chrome/browser/autocomplete/history_quick_provider_unittest.cc
chrome/common/crash_keys.cc
chrome/common/crash_keys.h