| commit | 6eacb391e4915718b9cac171d133a31376f11cde | |
| author | lazyboy@chromium.org <lazyboy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 18 Nov 2013 04:11:07 +0000 (18 04:11 +0000) | ||
| committer | lazyboy@chromium.org <lazyboy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 18 Nov 2013 04:11:07 +0000 (18 04:11 +0000) | ||
| tree | f8788bd7e2ec64236ba0194a5664e09f450127bd | treesnapshot (tar.gz zip) |
| parent | cb75dfcaf8714c9e3a7598d72ab8a6a808815cb0 | commitdiff |
winaura: Do not create WindowObservers for BrowserPlugin.
WindowObserver is not necessary for BrowserPlugin.
Moreover, if BrowserPlugin navigates to an Interstitial page,
tearing down its embedder causes a crash b/c it tries
to cast the Interstitial's WC's view to WCViewAura, which
actually is a WCViewGuest. The ToRenderWidgetHostViewAura does
not work in this scenario because the RWH's process points to
Interstitial's RenderProcess, whose IsGuest() is false. The
simpler fix hence is to get rid of WindowObserver for
BrowserPlugin.
This will also fix a flaky test on windows:
WebViewTest.InterstitialTeardown.
BUG=316298,297014
Test=On Windows Aura, load an app with a <webview> pointing
to a page that shows an interstitial, e.g. try navigating
to https://test.com. After the interstitial is visible, close
the app. The fix would make the browser not crash.
Review URL: https://codereview.chromium.org/72283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235600 0039d316-1c4b-4281-b951-d872f2087c98
WindowObserver is not necessary for BrowserPlugin.
Moreover, if BrowserPlugin navigates to an Interstitial page,
tearing down its embedder causes a crash b/c it tries
to cast the Interstitial's WC's view to WCViewAura, which
actually is a WCViewGuest. The ToRenderWidgetHostViewAura does
not work in this scenario because the RWH's process points to
Interstitial's RenderProcess, whose IsGuest() is false. The
simpler fix hence is to get rid of WindowObserver for
BrowserPlugin.
This will also fix a flaky test on windows:
WebViewTest.InterstitialTeardown.
BUG=316298,297014
Test=On Windows Aura, load an app with a <webview> pointing
to a page that shows an interstitial, e.g. try navigating
to https://test.com. After the interstitial is visible, close
the app. The fix would make the browser not crash.
Review URL: https://codereview.chromium.org/72283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235600 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/apps/web_view_browsertest.cc | diffblobblamehistory | |
| content/browser/web_contents/web_contents_view_aura.cc | diffblobblamehistory |