| commit | 718951168f69efc15318a713207c5cf9f6c62d5b | |
| author | amistry <amistry@chromium.org> | |
| Fri, 26 Jun 2015 23:53:20 +0000 (26 16:53 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 26 Jun 2015 23:54:10 +0000 (26 23:54 +0000) | ||
| tree | 3fd9fc7fcf3fcc1da7a392a34c078683b8166418 | treesnapshot (tar.gz zip) |
| parent | abfaea49e7495be66dfb7914d8df70404117b83d | commitdiff |
Fix a use-after-free error in ProxyResolverMojoFactory.
The callback run in ProxyResolverFactoryMojo::Job::OnConnectionError()
could delete |this|. In that situation, the following access to
|on_delete_callback_runner_| would be invalid since |this| would have
already been deleted.
BUG=501290
Review URL: https://codereview.chromium.org/1193103008
Cr-Commit-Position: refs/heads/master@{#336476}
The callback run in ProxyResolverFactoryMojo::Job::OnConnectionError()
could delete |this|. In that situation, the following access to
|on_delete_callback_runner_| would be invalid since |this| would have
already been deleted.
BUG=501290
Review URL: https://codereview.chromium.org/1193103008
Cr-Commit-Position: refs/heads/master@{#336476}
| net/proxy/proxy_resolver_factory_mojo.cc | diffblobblamehistory | |
| net/proxy/proxy_resolver_factory_mojo_unittest.cc | diffblobblamehistory |