| commit | 71fcb150d9e2cb5e2f05069177ac611ac9c189c0 | |
| author | toyoshim <toyoshim@chromium.org> | |
| Thu, 23 Oct 2014 07:17:59 +0000 (23 00:17 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 23 Oct 2014 07:18:17 +0000 (23 07:18 +0000) | ||
| tree | 5067da853f0f8b7d7b52a0fb632ad93e33701fe7 | treesnapshot (tar.gz zip) |
| parent | 7a0ddbb2ced7ed2117ae177773714968f66a66b5 | commitdiff |
Manage MIDI related objects and sessions' lifecycles correctly
Following changes are needed to maintain MIDIPortInfoList contents
consistent in each MidiMessageFilter instances when MidiManager
update the list asynchronously.
Essential changes:
- Call EndSession iff a session is open.
- Do not use client_id to communicate between browser and renderer.
Multiple clients are managed in a MidiMessageFilter existing in
each renderer.
Minor changes:
- Remove midi_manager_ checks in MIDIHost, and add CHECK insteads.
- Rename MidiManagerFilter::StartSession to MidiManagerFilter::AddClient
to be aligned with RemoveClient. A session can be shared with multiple
clients.
After this change, MidiManager::EndSession is called from each Renderer
and RendererHost at the right timing, e.g., GC collects the last MIDIAccess
reference in JavaScript. See, also http://crbug.com/424859.
BUG=424859
Review URL: https://codereview.chromium.org/662853003
Cr-Commit-Position: refs/heads/master@{#300851}
Following changes are needed to maintain MIDIPortInfoList contents
consistent in each MidiMessageFilter instances when MidiManager
update the list asynchronously.
Essential changes:
- Call EndSession iff a session is open.
- Do not use client_id to communicate between browser and renderer.
Multiple clients are managed in a MidiMessageFilter existing in
each renderer.
Minor changes:
- Remove midi_manager_ checks in MIDIHost, and add CHECK insteads.
- Rename MidiManagerFilter::StartSession to MidiManagerFilter::AddClient
to be aligned with RemoveClient. A session can be shared with multiple
clients.
After this change, MidiManager::EndSession is called from each Renderer
and RendererHost at the right timing, e.g., GC collects the last MIDIAccess
reference in JavaScript. See, also http://crbug.com/424859.
BUG=424859
Review URL: https://codereview.chromium.org/662853003
Cr-Commit-Position: refs/heads/master@{#300851}