| commit | 73d41c0f28f554afca1771020363ca0daee24195 | |
| author | pneubeck <pneubeck@chromium.org> | |
| Tue, 12 May 2015 12:28:48 +0000 (12 05:28 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 12 May 2015 12:29:12 +0000 (12 12:29 +0000) | ||
| tree | 961554ed9201a6d47e0dd28a7c6b49b4ea194002 | treesnapshot (tar.gz zip) |
| parent | 3e966cacd118b489ab195f03446812c7eaedfc8f | commitdiff |
Revert of Refactor the avatar button/icon class (patchset #14 id:320001 of https://codereview.chromium.org/1009403002/)
Reason for revert:
Very likely has caused the latest flakiness of
BrowserNonClientFrameViewAshTest.AvatarDisplayOnTeleportedWindow
and
BrowserNonClientFrameViewAshTest.AvatarMenuButtonHitTestOnChromeOS
on
ChromeOS dbg:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/2069
Original issue's description:
> Refactor the avatar button/icon class.
> Such that they are based on the same base class.
>
> BUG=452524
>
> Committed: https://crrev.com/56078ce434955a67159b59303f6691adb55d7ca1
> Cr-Commit-Position: refs/heads/master@{#329249}
TBR=noms@chromium.org,msw@chromium.org,yiyaoliu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=452524
Review URL: https://codereview.chromium.org/1139943002
Cr-Commit-Position: refs/heads/master@{#329394}
Reason for revert:
Very likely has caused the latest flakiness of
BrowserNonClientFrameViewAshTest.AvatarDisplayOnTeleportedWindow
and
BrowserNonClientFrameViewAshTest.AvatarMenuButtonHitTestOnChromeOS
on
ChromeOS dbg:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/2069
Original issue's description:
> Refactor the avatar button/icon class.
> Such that they are based on the same base class.
>
> BUG=452524
>
> Committed: https://crrev.com/56078ce434955a67159b59303f6691adb55d7ca1
> Cr-Commit-Position: refs/heads/master@{#329249}
TBR=noms@chromium.org,msw@chromium.org,yiyaoliu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=452524
Review URL: https://codereview.chromium.org/1139943002
Cr-Commit-Position: refs/heads/master@{#329394}