Revert of Ozone support for device special cases in keyboard event rewriting. (patchs...
commit742b7ff8c1b4eda8c740ee586efa6ca07fc2930b
authorkpschoedel <kpschoedel@chromium.org>
Thu, 23 Apr 2015 14:18:17 +0000 (23 07:18 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 23 Apr 2015 14:18:25 +0000 (23 14:18 +0000)
tree3312698bee144d9f1951a669d2466eb7f77ce026
parent1a285faf58a6bac870e394569258818958f812f8
Revert of Ozone support for device special cases in keyboard event rewriting. (patchset #6 id:120001 of https://codereview.chromium.org/1073573002/)

Reason for revert:
Bisected this CL for crbug.com/478605.

Chrome crashes upon start-up in ASAN builds, suggesting there is a invalid memory access somewhere in this CL.

Original issue's description:
> Ozone support for device special cases in keyboard event rewriting.
>
> Keyboard event rewriting has some special cases keyed on the device
> name (Apple keyboards) or USB VID/PID (Hotrod remote), which had been
> handled by special-case device inspection under X11, and not handled
> at all under Ozone. This moves the properties to ui::DeviceDataManager
> and makes the use in chromeos::EventRewriter platform-independent.
>
> BUG=471753
>
> Committed: https://crrev.com/711f2fc883c05bb10466fb65fdaf9bc10c909b23
> Cr-Commit-Position: refs/heads/master@{#325660}

TBR=sadrul@chromium.org,spang@chromium.org,derat@chromium.org,kpschoedel@chromium.org
BUG=471753, 478605

Review URL: https://codereview.chromium.org/1097393011

Cr-Commit-Position: refs/heads/master@{#326508}
30 files changed:
ash/test/virtual_keyboard_test_helper.cc
ash/touch/touch_transformer_controller_unittest.cc
ash/touch/touchscreen_util_unittest.cc
ash/virtual_keyboard_controller_unittest.cc
chrome/browser/chromeos/events/event_rewriter.cc
ui/events/devices/input_device.cc
ui/events/devices/input_device.h
ui/events/devices/keyboard_device.cc
ui/events/devices/keyboard_device.h
ui/events/devices/touchscreen_device.cc
ui/events/devices/touchscreen_device.h
ui/events/devices/x11/device_data_manager_x11_unittest.cc
ui/events/devices/x11/touch_factory_x11.cc
ui/events/devices/x11/touch_factory_x11.h
ui/events/event.cc
ui/events/ozone/evdev/event_converter_evdev.cc
ui/events/ozone/evdev/event_converter_evdev.h
ui/events/ozone/evdev/event_converter_evdev_impl.cc
ui/events/ozone/evdev/event_device_info.cc
ui/events/ozone/evdev/event_device_info.h
ui/events/ozone/evdev/event_factory_evdev.cc
ui/events/ozone/evdev/input_device_factory_evdev.cc
ui/events/ozone/evdev/keyboard_evdev.cc
ui/events/ozone/evdev/keyboard_evdev.h
ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc
ui/events/ozone/evdev/tablet_event_converter_evdev.cc
ui/events/ozone/evdev/touch_event_converter_evdev.cc
ui/events/ozone/evdev/touch_event_converter_evdev.h
ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc
ui/events/platform/x11/x11_hotplug_event_handler.cc