| commit | 7b2d3d199ebcd0109d0ba4fd71d201510408c789 | |
| author | creis <creis@chromium.org> | |
| Thu, 12 Feb 2015 23:29:50 +0000 (12 15:29 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 12 Feb 2015 23:30:36 +0000 (12 23:30 +0000) | ||
| tree | 46f8e09b3c9f6fe79308e5adf59cc82926358e90 | treesnapshot (tar.gz zip) |
| parent | 75c2b017bd1ab668d7f20fde6af6f5506a842c02 | commitdiff |
Call ComputeWebKitPrefs on the correct RVH, and remove dead code.
RenderViewHost was calling out to WebContents to get the URL, but it
was getting the wrong URL (e.g., possibly the transient one) and then
never looking at it. Worse, WebContents then called ComputeWebkitPrefs
on the wrong RVH (the old one, not the pending one).
This only seems to come up in corner cases, like chrome://history on
Android when Javascript is disabled.
BUG=454063
TEST=See bug.
TBR=jam
Review URL: https://codereview.chromium.org/919933002
Cr-Commit-Position: refs/heads/master@{#316081}
RenderViewHost was calling out to WebContents to get the URL, but it
was getting the wrong URL (e.g., possibly the transient one) and then
never looking at it. Worse, WebContents then called ComputeWebkitPrefs
on the wrong RVH (the old one, not the pending one).
This only seems to come up in corner cases, like chrome://history on
Android when Javascript is disabled.
BUG=454063
TEST=See bug.
TBR=jam
Review URL: https://codereview.chromium.org/919933002
Cr-Commit-Position: refs/heads/master@{#316081}
27 files changed: