| commit | 7c7c3d4140fd94d394444102c9e1953b386f291f | |
| author | tapted <tapted@chromium.org> | |
| Tue, 25 Aug 2015 23:23:44 +0000 (25 16:23 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 25 Aug 2015 23:24:37 +0000 (25 23:24 +0000) | ||
| tree | 3cf750b220549f3f9b0a256f9e31d6d474df5ce8 | treesnapshot (tar.gz zip) |
| parent | 823628121c298b64ee119ae471d8e961dd50b515 | commitdiff |
Repair menu border on Desktop Windows and Linux
This regressed in r344651 which assumed MenuConfig::InitAura() was
always called.
Actually, (e.g.) Desktop Linux currently uses only MenuConfig data
member initializers for its values.
So to fix, change MenuConfig::use_outer_border to default to true. Set
it unconditionally to false in MenuConfig::InitAura() (which is only
called for Ash windows), and on mac.
Verified:
- Windows, Linux: border (except in --open-ash),
- chromeos, Mac: no border.
BUG=523914
TEST=Visual
Review URL: https://codereview.chromium.org/1303313005
Cr-Commit-Position: refs/heads/master@{#345479}
This regressed in r344651 which assumed MenuConfig::InitAura() was
always called.
Actually, (e.g.) Desktop Linux currently uses only MenuConfig data
member initializers for its values.
So to fix, change MenuConfig::use_outer_border to default to true. Set
it unconditionally to false in MenuConfig::InitAura() (which is only
called for Ash windows), and on mac.
Verified:
- Windows, Linux: border (except in --open-ash),
- chromeos, Mac: no border.
BUG=523914
TEST=Visual
Review URL: https://codereview.chromium.org/1303313005
Cr-Commit-Position: refs/heads/master@{#345479}
| ui/views/controls/menu/menu_config.cc | diffblobblamehistory | |
| ui/views/controls/menu/menu_config_aura.cc | diffblobblamehistory | |
| ui/views/controls/menu/menu_config_mac.mm | diffblobblamehistory |